Skip to content

Unpin testing-tools dependencies#326

Merged
nightkr merged 3 commits intomainfrom
bugfix/unpin-testing-tools-deps
Feb 8, 2023
Merged

Unpin testing-tools dependencies#326
nightkr merged 3 commits intomainfrom
bugfix/unpin-testing-tools-deps

Conversation

@nightkr
Copy link
Copy Markdown
Contributor

@nightkr nightkr commented Feb 8, 2023

Debian seems to prune old versions of packages from their repository regularly. After discussing with @razvan I decided to remove the pins, since updating the bounds would just cause the problem to return once the new versions were also pruned, meaning that we still wouldn't have reliable reproducibility.

Fixes #324.

@nightkr nightkr requested a review from a team February 8, 2023 10:32
Copy link
Copy Markdown
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me

@nightkr nightkr merged commit 2c8e041 into main Feb 8, 2023
@nightkr nightkr deleted the bugfix/unpin-testing-tools-deps branch February 8, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix testing-tools dockerfile bitrot

2 participants